Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: solfege - music education software https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219653 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2006-12-17 04:43 EST ------- Well, this time I only checked for packaging issue and not checked this package for its funtion. A. From http://fedoraproject.org/wiki/Packaging/Guidelines : * Filesystem Layout - Usually when a wrapper script for the original binary is needed, the original binary should be where user's path are not passed, which is usually %{_libexecdir}. * Use rpmlint - rpmlint (for FC-devel) is not silent, for which please see below * Requires - Well, python related dependencies are not checked automatically by rpmbuild process and then should be checked manually. -- For example, /usr/share/solfege/src/utils.py contails: ----------------------------------------- import gtk ----------------------------------------- This means that this package (solfege) should need "Requires: pygtk2". -- And another example is that /usr/share/solfege/soundcard/midifilesynth.py includes the line: ----------------------------------------- import win32api ----------------------------------------- However, what package provides win32api python module? (or can this file be ignored??) * BuildRequires - libxslt-devel Please check whether this should be whether "libxslt-devel" or "libxslt", since it seems only /usr/bin/xsltproc is used and this package is included in libxslt, not -devel pacakge. * Desktop files -------------------------------------------- Categories=GNOME;Application;AudioVideo;Audio;Education;X-Fedora; -------------------------------------------- Categories "Application" "X-Fedora" is deprecated from desktop-file-utils >= 0.11 and these should be removed (this is also applied for FC5/6). For FC-devel, these causes rpmlint warnings/errors. * Documentation - /usr/share/doc/solfege-3.6.4/{AUTHORS,README} contain non-UTF8 character(s). Please change the encodings of these files to UTF-8. * Timestamps - This package (solfege) contains many image files and for these files timestamps should be kept to show correctly when these files are created. For these purpose: 1. ----------------------------------------------- export INSTALL="%{__install} -c -p" ----------------------------------------------- is needed before ----------------------------------------------- %configure --enable-docbook-stylesheet=%stylesheet ----------------------------------------------- line to pass INSTALL environment to Makefile.in 2. ------------------------------------------------ %{__sed} -i.stamp -e 's|shutil\.copy|shutil.copy2|' tools/pcopy.py ------------------------------------------------ is needed at %prep stage to keep timestamps on image files. B. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines : = this is okay. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review