Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=627637 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx Status Whiteboard|StalledSubmitter | Flag| |fedora-review? --- Comment #7 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2011-02-20 16:29:18 EST --- Some notes: * Clean up of old miscs - Please clean up old miscs no longer needed on Fedora, like * BuildRoot tag * "rm -rf $RPM_BUILD_ROOT" at the top of %install * %clean * $RPM_BUILD_ROOT vs %buildroot / coding style - Please choose to use one style, not both. https://fedoraproject.org/wiki/Packaging/Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS - Also, using both "install -d" and "mkdir" seems a bit confusing, I recommend to use one style. * Timestamp - When using "cp" or "install" commands, please add "-p" option to keep timestamp on installed files. https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps * Path - Would you explain why you want to install "qroneko" binary to %_sbindir, not under %_bindir? (it seems that qroneko can be lauched as normal user). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review