Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678887 Sergio Belkin <sebelk@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sebelk@xxxxxxxxx --- Comment #2 from Sergio Belkin <sebelk@xxxxxxxxx> 2011-02-20 14:06:07 EST --- Hi Hans I am (still) not member of packaging group, however I hope my review be useful: AFAIK these are non-fatal errors: 1. BuildRoot is not needed anymore. 2. The same goes for clean section. http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag The following is a fatal error, sorry for my insolenece taking into account that I'm not still of packaging group... 3. I don't know if I miss something but I see that koji is failing trying to compile the package: main.c:25:16: fatal error: gd.h: No such file or directory The same applies for mock. You should add BuildRequieres: gd-devel Also, is failing to find st2205.h, fix the %build section accordingly. Greets -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review