Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-twisted-words - Twisted Words contains Instant Messaging implementations https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216106 kevin@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |kevin@xxxxxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From kevin@xxxxxxxxx 2006-12-16 14:31 EST ------- OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (MIT) OK - License field in spec matches See below - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 37d34da233aefe4a7a41b97bc9222b6a TwistedWords-0.4.0.tar.bz2 37d34da233aefe4a7a41b97bc9222b6a TwistedWords-0.4.0.tar.bz2.1 See below - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. See below - No rpmlint output. OK - final provides and requires are sane SHOULD Items: OK - Should build in mock. x386/x86_64 - Should build on all supported archs OK - Should have dist tag OK - Should package latest version Issues: 1. The obligatory comment about the %{python} macro. ;) 2. Should include LICENSE and NEWS as %doc files. 3. Needs BuildRequires: python-devel on fc7/devel at least. 4. rpmlint says: E: python-twisted-words no-binary (which can be ignored in this case) 5. Should the Requires on python-twisted-core be versioned? I just noticed it isn't here or any of the other python-twisted-* packages. Is core likely to upgrade in a way that is compatible with all the subpackages? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review