Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676159 --- Comment #10 from Tim Niemueller <tim@xxxxxxxxxxxxx> 2011-02-20 05:45:29 EST --- (In reply to comment #9) > Hm. Looks like crlibm use scslib not fully correctly with private header. Ok. Yeah, one author, similar macros, included lib, that's simply a consequence. > 1) Makefile.am contain string "SUBDIRS = $(MAYBE_SCS) . tests" which broke > building (tried to add scs subdir). Changing it to "SUBDIRS = . tests". But: Looks as if you built without the libscs-devel installed. Did you use the latest one posted, this contains the BR. If libscs-devel is installed MAYBE_SCS is empty. I have added this do have a chance to get this included uptsream, i.e. you can build with and without system-wide syslib. But the non-sys-wide is not fully working yet, but this is irrelevant for the package, where we only need the case w/sys-wide. > 2) Tests are compiled, but not used both during prepearation and in final rpm. > Removal their compilation leads to at least removal tbx_timing.h header from > patch. What is good. Good point, eliminating tests altogether would be a good thing. I would like to make that a configure flag later on, again, to get this included upstream. But for now the current state should be fine once we find what your compilation error in 1) was. This shouldn't be a blocker on the review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review