Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676941 Patryk Obara <dreamer.tan@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dreamer.tan@xxxxxxxxx --- Comment #1 from Patryk Obara <dreamer.tan@xxxxxxxxx> 2011-02-19 15:47:39 EST --- (This is not normal review, because I am novice packager, but a bit of of feedback): 1) host files somewhere other than 4shared.com - it's impossible to download them using wget :( Public dropbox dir or hosting files on http://fedorapeople.org would work better :) 2) Source0 url: better use: http://eiskaltdc.googlecode.com/files/eiskaltdcpp-%{version}.tar.bz2 3) unfortunately, %build step failed for me: CMake Error at /usr/share/cmake/Modules/FindOpenSSL.cmake:93 (MESSAGE): Could NOT find OpenSSL Call Stack (most recent call first): CMakeLists.txt:70 (find_package) 4) I don't think you need this: %install rm -rf %{buildroot} buildroot is always cleaned before %install step 5) Why does %dir do? I can't find it in guidelines/documentation anywhere - I don't think it's necessary. 6) change %doc to %doc COPYING LICENSE You could also add ChangeLog files in doc 7) update date in %changelog, it says February 2010 ;) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review