Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666943 --- Comment #4 from Christoph Wickert <cwickert@xxxxxxxxxxxxxxxxx> 2011-02-19 05:27:15 EST --- > - According to COPYING.extras, some of the icons are licensed under GPLv2 only. > Thus, the License tag should be "GPLv3+ and GPLv2". fixed > - The macro file texinfo.tex shouldn't be packaged as it's of no use here. removed > - If you want to maintain ignuit for EPEL < 6 too, you must use scrollkeeper > rather than rarian (and call scrollkeeper-update in %post/%postun). I have started doing this, but it ended in a mess: - RHEL < 6 doesn't know the gconf macros, so I'd need to use some "%if 0%{?fedora} || 0%{?rhel} >= 6 ... %else ... %endif" voodoo. - EPEL 4 needs an additional "killall -HUP gconfd-2 > /dev/null || :" - RHEL < 6 doesn't have %posttrans, I'd need to change the icon-cache scriptets. In the end the nested conditionals became longer than the current spec and I have no intentions to maintain this in EPEL anyway, so I decided it's not worth the effort. I also switched from desktop-file-validate to desktop-file-install to remove "Encoding" (obsolete) and "MimeType" (empty) from the desktop file. SRPM: http://cwickert.fedorapeople.org/review/ignuit-0.0.16-2.fc16.src.rpm SPEC: http://cwickert.fedorapeople.org/review/ignuit.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review