Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=634760 Sergio Belkin <sebelk@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sebelk@xxxxxxxxx --- Comment #1 from Sergio Belkin <sebelk@xxxxxxxxx> 2011-02-18 13:13:24 EST --- Hi, I am not still member of packaging group, however I hope that you find my casual review useful: 1. You use localstatedir /var/amavis Why? AFAIK amavisd-new in fedora doesn't use that directory: repoquery -l amavisd-new | grep "var\/amavis" |wc -l 0 2. BuildRoot: and clean section are not needed anymore. 3. Beware you have some issue about initscript file, run rpmlint, you should not enable a service by default, take a look at https://fedoraproject.org/wiki/Packaging/SysVInitScript. Also you will find interesting http://fedoraproject.org/wiki/Packaging:Tmpfiles.d and http://fedoraproject.org/wiki/Features/var-run-tmpfs. 4. Also this is no an error, but be aware that you're not using dist tag: http://fedoraproject.org/wiki/DistTag Hope that helps. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review