Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674666 Luke Macken <lmacken@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(tla@xxxxxxxxx) --- Comment #5 from Luke Macken <lmacken@xxxxxxxxxx> 2011-02-17 22:30:22 EST --- (In reply to comment #4) > Package Review > ============== > Issues: > [!] : MUST - All build dependencies are listed in BuildRequires, except for any > that are listed in the exceptions section of Packaging Guidelines. > BuildRequires: python2-devel is missing Added. > (https://fedoraproject.org/wiki/Packaging:Python#BuildRequires) > [!] : SHOULD - Spec use %global instead of %define. > %define modname translationstring, should be %global modname > translationstring Fixed. Spec URL: http://lmacken.fedorapeople.org/rpms/python-translationstring.spec SRPM URL: http://lmacken.fedorapeople.org/rpms/python-translationstring-0.3-1.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review