Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674671 Luke Macken <lmacken@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(tla@xxxxxxxxx) --- Comment #6 from Luke Macken <lmacken@xxxxxxxxxx> 2011-02-17 22:25:20 EST --- (In reply to comment #5) > Package Review > ============== > [!] : MUST - Rpmlint output is silent. > python-repoze-lru.src: W: non-coherent-filename > python-repoze-lru-0.3-1.fc13.src.rpm python-repoze-lru-0.3-1.fc14.src.rpm > 1 packages and 0 specfiles checked; 0 errors, 1 warnings. rpmlint is silent on the fc14.src.rpm below. > [!] : MUST - All build dependencies are listed in BuildRequires, except for any > that are listed in the exceptions section of Packaging Guidelines. > BuildRequires: python2-devel is missing > (https://fedoraproject.org/wiki/Packaging:Python#BuildRequires) Added. > [!] : SHOULD - Spec use %global instead of %define. > %define modname repoze.lru should be %global instead Fixed. Spec URL: http://lmacken.fedorapeople.org/rpms/python-repoze-lru.spec SRPM URL: http://lmacken.fedorapeople.org/rpms/python-repoze.lru-0.3-1.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review