Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=672845 VÃt Ondruch <vondruch@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |vondruch@xxxxxxxxxx Flag| |fedora-review? --- Comment #2 from VÃt Ondruch <vondruch@xxxxxxxxxx> 2011-02-17 11:11:30 EST --- I am taking this one for review. * New upstream version available - Please try to update to the latest version available upstream. 1.4 ATM. * License - The code is release under Artistic 2.0 license https://github.com/djberg96/net-ping/blob/master/README#L41 - Please update the license field accordingly: License: Artistic 2.0 * Unnecessary macros - The ruby_sitelib and ruby_sitearch macros are not in use in this package. Please remove them from top of the spec file. * Splitting out document files - Please consider to create -doc subpackage and move the following files / directories into -doc --------------------------------------------------- %doc %{geminstdir}/doc/ping.txt %doc %{gemdir}/doc/%{gemname}-%{version} %{geminstdir}/Rakefile %{geminstdir}/test %{geminstdir}/net-ping.gemspec %{geminstdir}/MANIFEST %{geminstdir}/CHANGES %{gemdir}/doc/%{gemname}-%{version} --------------------------------------------------- * Cleaning - "rm -rf %{buildroot}" at the top of %install is no longer needed: https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean * Test - Please add build time test suite execution: BuildRequires: rubygem(test-unit) %check pushd %{buildroot}%{geminstdir} RUBYOPT="Ilib" testrb2 test/test_net_ping.rb popd * Koji - Build looks fine http://koji.fedoraproject.org/koji/taskinfo?taskID=2846629 * rpmlint - Everything OK. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review