[Bug 218258] Review Request: audacious-docklet - a docklet plugin for Audacious

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: audacious-docklet - a docklet plugin for Audacious


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218258


fedora@xxxxxxxxxxxxxxxxxxxx changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From fedora@xxxxxxxxxxxxxxxxxxxx  2006-12-15 17:25 EST -------
(In reply to comment #8)
> Sorry for my mistakes.

Once again: There's no need for an excuse. You are new to Fedora Extras, but you
are doing fine. :)

REVIEW for 
887e3df8edb6a71276a6c1abb3be1bcb  audacious-docklet-0.1.1-1.src.rpm

MUST Items:
FAIL - rpmlint is not happy with the package:
  rpmlint audacious-docklet-0.1.1-1.fc6.i386.rpm 
  W: audacious-docklet no-version-in-last-changelog
  E: audacious-docklet zero-length /usr/share/doc/audacious-docklet-0.1.1/README

To fix these:
- Add the version to the changelog entry:
  * Thu Dec 14 2006 Yu Fan <yufanyufan at gmail dot com> - 0.1.1-1
- Remove README from doc as long as it's empty.

OK - package meets naming guidelines
OK - spec file meets naming guidelines
OK - package meets package guidelines
OK - license open-source compatible (GPL)
OK - license in spec file matches actual license
OK - license included in %doc
OK - spec file in American English
OK - spec file is legible

FAIL - source in SRPM doesn't match upstream source, md5 is
  7503981a0a0ee229e5bdbe18553810db while upstream is
  9b51ac5fd179ede8d0d75be12f920ed2
Please download a new source tarball for the SRPM.

OK - package builds on i386
OK - all build dependencies listed in BuildRequires
OK - none of the exceptions of packaging guidelines in BuildRequires
OK - locales handled correctly with %find_lang
OK - no shared libs to worry about
OK - package is not relocatable
OK - package owns all directories that it creates
OK - no duplicate files in %files section
OK - permissions and %defattr correct 
OK - clean section with "rm -rf $RPM_BUILD_ROOT" present
OK - macro usage consistent
OK - code, not content
OK - no large docs
OK - docs don't affect runtime
OK - no headers, static libs or pkgconfig files, no -devel package needed
OK - no libtool archives
OK - plugin, no need for a *.desktop file.
OK - package doesn't own files/directories owned by other packages

SHOULD items:
OK - package builds in mock (Core 6 and devel on i386)
OK - package functions as described (but see note below)
OK - package uses disttag

NEEDSWORK

Please fix the issues I mentioned before I can approve this package.

Also I found audacious ui freezing when I choose "Preferences" from the docklet
right after the start. This only happens when the prefes window is showing
"Appearence" and if it has net been opened before in the audacious session. If I
opened the prefs before from the audaciuos main window or if I selected
something else but "Appearance", everything works fine.

Do you see the same behaviour? If so:
- Please notify upstream. Not sure if this is an audacious or a docklet bug.
- Do not build this package for branches other than devel. I'd like to see this
fixed before the package enters FE 5/6.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]