Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=677693 --- Comment #8 from Petr Sabata <psabata@xxxxxxxxxx> 2011-02-16 09:29:10 EST --- (In reply to comment #7) > Please change your Group tag to "Amusements/Games". > I wasn't sure about what category to choose. TinTin++ isn't actually a game, just a client. In theory, it could be used to access other services as well. > Did you asked the upstream author to fix permissions on doc files? > Not yet. > Consider using "%doc %attr" instead. > > Why not keep "mods" subdir? > > ### > chmod 644 docs/* && mv -v docs/* . > ### > > There is no need to move files from docs/ ... Just add an entry for docs/* Would you find this okay? --- tintin.spec 2011-02-15 19:06:36.085563092 +0100 +++ tintin.spec.new 2011-02-16 15:27:17.439563027 +0100 @@ -1,6 +1,6 @@ Name: tintin Version: 2.00.5 -Release: 3%{?dist} +Release: 4%{?dist} Summary: TinTin++, aka tt++, is a free MUD client Group: Applications/Internet License: GPLv2+ @@ -38,26 +38,28 @@ %install cd src make install DESTDIR=%{buildroot} -cd .. -chmod 644 COPYING CREDITS FAQ INSTALL README -chmod 644 SCRIPTS -chmod 644 docs/* && mv -v docs/* . -chmod 644 mods/*.mods && mv -v mods/*.mods . +cd ../mods iconv -f latin1 -t utf8 igr.mods > igr.mods.utf8 && mv igr.mods.utf8 igr.mods %files %defattr(-,root,root,-) -%doc COPYING CREDITS FAQ INSTALL README *.mods +%doc %attr(0644,root,root) COPYING +%doc %attr(0644,root,root) CREDITS FAQ INSTALL README +%doc %attr(0755,root,root) mods/ +%doc %attr(0644,root,root) mods/* %{_bindir}/tt++ %files doc %defattr(-,root,root,-) -%doc COPYING -%doc chat_protocol.txt -%doc tintin19.txt -%doc SCRIPTS +%doc %attr(0644,root,root) COPYING +%doc %attr(0644,root,root) SCRIPTS +%doc %attr(0755,root,root) docs +%doc %attr(0644,root,root) docs/* %changelog +* Wed Feb 16 2011 Petr Sabata <psabata@xxxxxxxxxx> - 2.00.5-4 +- Changed documentation files structure, removed chmod's in favor of attr's + * Tue Feb 15 2011 Petr Sabata <psabata@xxxxxxxxxx> - 2.00.5-3 - igr.mods now gets converted to proper utf8 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review