Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=677043 Christopher Aillon <caillon@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caillon@xxxxxxxxxx --- Comment #2 from Christopher Aillon <caillon@xxxxxxxxxx> 2011-02-15 17:51:18 EST --- Not a formal review, just some quick comments: 1. There's no need to specify a BuildRoot, or remove it in %install, or for the %clean section to exist. Feel free to kill those parts. (Yes rpmdev-newspec generates them, but they don't need to be there). See http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag 2. The following is unnecessary mkdir -p %{buildroot}%{_docdir}/%{name}-%{version} cp {COPYING,NEWS,README} %{buildroot}%{_docdir}/%{name}-%{version} It happens automatically with %doc COPYING NEWS README 3. You should preserve timestamps. See http://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps 4. It seems like it's not needed to run make at all... so don't :-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review