Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=677693 --- Comment #3 from Petr Pisar <ppisar@xxxxxxxxxx> 2011-02-15 12:52:05 EST --- Spec file changes: --- tintin.spec 2011-02-15 17:13:04.000000000 +0100 +++ tintin.spec.1 2011-02-15 18:26:41.000000000 +0100 @@ -1,11 +1,12 @@ Name: tintin Version: 2.00.5 -Release: 1%{?dist} +Release: 2%{?dist} Summary: TinTin++, aka tt++, is a free MUD client Group: Applications/Internet -License: GPLv2 +License: GPLv2+ URL: http://tintin.sourceforge.net/ -Source0: http://sf.net/projects/%{name}/files/TinTin%2B%2B%20Source%20Code/2.00.5/%{name}-%{version}.tar.gz +Source0: http://garr.dl.sourceforge.net/project/%{name}/TinTin%2B%2B%20Source%20Code/%{version}/%{name}-%{version}.tar.gz +Patch0: tintin-2.00.5-destdir.patch BuildRequires: pcre-devel BuildRequires: zlib-devel @@ -13,44 +14,54 @@ TinTin++, aka tt++, is a free MUD client for Mac OS X, Linux, and Windows. The Windows port named WinTin++ (using the PuTTY terminal) is available for those who do not use Cygwin (A Linux/Unix emulator for Windows) and runs on -Windows Xp, Windows Vista, and Windows 7. Besides MUDs, TinTin++ also works +Windows XP, Windows Vista, and Windows 7. Besides MUDs, TinTin++ also works well with MUSH, Rogue, BBS, and Linux servers. %package doc Summary: TinTin++ documentation and examples -Group: Applications/Internet -License: GPLv2 +Group: Documentation +License: GPLv2+ +BuildArch: noarch %description doc TinTin++, aka tt++, MUD client documentation and examples. %prep %setup -q -n tt +%patch0 -p1 -b .destdir %build cd src -%configure --bindir=%{buildroot}%{_bindir} +%configure make %{?_smp_mflags} %install cd src -make install +make install DESTDIR=%{buildroot} cd .. chmod 644 COPYING CREDITS FAQ INSTALL README chmod 644 SCRIPTS chmod 644 docs/* && mv -v docs/* . +chmod 644 mods/*.mods && mv -v mods/*.mods . %files %defattr(-,root,root,-) -%doc COPYING CREDITS FAQ INSTALL README +%doc COPYING CREDITS FAQ INSTALL README *.mods %{_bindir}/tt++ %files doc %defattr(-,root,root,-) +%doc COPYING %doc chat_protocol.txt %doc tintin19.txt %doc SCRIPTS %changelog +* Tue Feb 15 2011 Petr Sabata <psabata@xxxxxxxxxx> - 2.00.5-2 +- Source corrected +- Description spelling corrected +- TODO and Changelogs packaged, COPYING added to the doc package +- Changed build section, added DESTDIR patch + * Tue Feb 15 2011 Petr Sabata <psabata@xxxxxxxxxx> - 2.00.5-1 - Package prepared for review > FIX: License should be GPLv2+ (src/main.c). The same applies for doc > sub-package. -License: GPLv2 +License: GPLv2+ Ok. > FIX: Source0 returns HTML file instead of the tar ball. -Source0: http://sf.net/projects/%{name}/files/TinTin%2B%2B%20Source%20Code/2.00.5/%{name}-%{version}.tar.gz +Source0: http://garr.dl.sourceforge.net/project/%{name}/TinTin%2B%2B%20Source%20Code/%{version}/%{name}-%{version}.tar.gz Ok. > FIX: Make `doc' sub-package noarch. +BuildArch: noarch Ok. > %configure --bindir overrode because Makefile does not respect DESTDIR. Ok. > TODO: Patch Makefile.in to respect DESTDIR and report it to upstream. Ok. NOTE: The patch works but better way is to inject DESTDIR right at mkdir and cp because $(bindir) is run-time path and more complex packages can use it at compile time. > FIX: Package COPYING into `doc' sub-package as it's independent. +%doc COPYING Ok. $ rpmlint tintin.spec ../SRPMS/tintin-2.00.5-2.fc14.src.rpm ../RPMS/x86_64/tintin-2.00.5-2.fc14.x86_64.rpm ../RPMS/noarch/tintin-doc-2.00.5-2.fc14.noarch.rpm tintin.src: W: spelling-error Summary(en_US) tt -> rt, tr, t tintin.src: W: spelling-error %description -l en_US tt -> rt, tr, t tintin.x86_64: W: spelling-error Summary(en_US) tt -> rt, tr, t tintin.x86_64: W: spelling-error %description -l en_US tt -> rt, tr, t tintin.x86_64: W: file-not-utf8 /usr/share/doc/tintin-2.00.5/igr.mods tintin.x86_64: W: no-manual-page-for-binary tt++ tintin-doc.noarch: W: spelling-error %description -l en_US tt -> rt, tr, t 3 packages and 1 specfiles checked; 0 errors, 7 warnings. FIX: Convert igr.mods into UTF-8. $ rpm -q -vl -p ../RPMS/x86_64/tintin-2.00.5-2.fc14.x86_64.rpm -rwxr-xr-x 1 root root 359080 Ãno 15 18:42 /usr/bin/tt++ drwxr-xr-x 2 root root 0 Ãno 15 18:42 /usr/share/doc/tintin-2.00.5 -rw-r--r-- 1 root root 13793 Äec 9 2009 /usr/share/doc/tintin-2.00.5/1.5.mods -rw-r--r-- 1 root root 18009 Äec 5 2009 /usr/share/doc/tintin-2.00.5/COPYING -rw-r--r-- 1 root root 1916 pro 28 18:10 /usr/share/doc/tintin-2.00.5/CREDITS -rw-r--r-- 1 root root 4840 pro 28 18:37 /usr/share/doc/tintin-2.00.5/FAQ -rw-r--r-- 1 root root 1209 srp 2 2009 /usr/share/doc/tintin-2.00.5/INSTALL -rw-r--r-- 1 root root 6736 pro 28 18:40 /usr/share/doc/tintin-2.00.5/README -rw-r--r-- 1 root root 32912 Äec 9 2009 /usr/share/doc/tintin-2.00.5/dsc.mods -rw-r--r-- 1 root root 79424 pro 28 18:42 /usr/share/doc/tintin-2.00.5/igr.mods -rw-r--r-- 1 root root 5735 Äec 9 2009 /usr/share/doc/tintin-2.00.5/pkj.mods -rw-r--r-- 1 root root 3357 Äec 9 2009 /usr/share/doc/tintin-2.00.5/rse.mods -rw-r--r-- 1 root root 8615 Äec 9 2009 /usr/share/doc/tintin-2.00.5/svr.mods -rw-r--r-- 1 root root 3105 Äec 9 2009 /usr/share/doc/tintin-2.00.5/xin.mods -rw-r--r-- 1 root root 3347 Äec 9 2009 /usr/share/doc/tintin-2.00.5/ycj.mods $ rpm -q -vl -p ../RPMS/noarch/tintin-doc-2.00.5-2.fc14.noarch.rpm drwxr-xr-x 2 root root 0 Ãno 15 18:42 /usr/share/doc/tintin-doc-2.00.5 -rw-r--r-- 1 root root 18009 Äec 5 2009 /usr/share/doc/tintin-doc-2.00.5/COPYING -rw-r--r-- 1 root root 6196 led 23 2010 /usr/share/doc/tintin-doc-2.00.5/SCRIPTS -rw-r--r-- 1 root root 8477 Äec 9 2009 /usr/share/doc/tintin-doc-2.00.5/chat_protocol.txt -rw-r--r-- 1 root root 11181 Äec 9 2009 /usr/share/doc/tintin-doc-2.00.5/tintin19.txt File permissions and layout is Ok. Package builds in F16 (http://koji.fedoraproject.org/koji/taskinfo?taskID=2842109). Ok. Otherwise the package is in line Fedora packaging guide lines. Please correct all `FIX' prefixed issues and submit new spec file. Resolution: Package NOT approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review