Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666311 Rich Mattes <richmattes@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |richmattes@xxxxxxxxx --- Comment #3 from Rich Mattes <richmattes@xxxxxxxxx> 2011-02-15 00:02:41 EST --- I'm very interested in this package making it into Fedora. I'm not a sponsor so I cannot complete a review of this package, but I'd still like to give you some feedback on some problems I see. * You do not need to call "strip" on the Fritzing binary, rpmbuild will take care of that. * It looks like the package is building against a bundled boost-1.43, quazip, and qtlockedfile (located under src/lib in the source.) Bundling libraries that are available system-wide is not acceptable as per http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries You'll need to remove the bundled libraries during %prep as per http://fedoraproject.org/wiki/Packaging:Treatment_Of_Bundled_Libraries and patch the buildsystem so it detects and builds against system-installed libraries. A folder called "ff" also exists with a couple of source files, but I cannot find an upstream project that provides them. * You should export CXXFLAGS="%{optflags}" before calling qt4_qmake so the package is built with Fedora's default flags (optimization level, debug level, etc.) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review