Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674009 --- Comment #2 from Peter Lemenkov <lemenkov@xxxxxxxxx> 2011-02-13 04:20:47 EST --- Koji scratchbuild for F-15: http://koji.fedoraproject.org/koji/taskinfo?taskID=2836716 REVIEW: Legend: + = PASSED, - = FAILED, 0 = Not Applicable +/- rpmlint is NOT silent sulaco ~: rpmlint Desktop/bitten-* bitten.src: W: spelling-error Summary(en_US) plugin -> plug in, plug-in, plugging bitten-master.noarch: W: spelling-error Summary(en_US) plugin -> plug in, plug-in, plugging bitten-master.noarch: W: no-documentation bitten-master.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/bitten/templates/bitten_admin_configs.html bitten-master.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/bitten/templates/bitten_config.html bitten-master.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/bitten/templates/bitten_summary_coverage.html bitten-master.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/bitten/templates/bitten_admin_master.html bitten-master.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/bitten/templates/bitten_summary_tests.html bitten-master.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/bitten/templates/bitten_build.html bitten-slave.noarch: W: no-documentation bitten-slave.noarch: E: non-readable /etc/bitten-slave.conf 0640 bitten-slave.noarch: W: no-manual-page-for-binary bitten-slave ^^^ these messages already explained in the comment above. bitten-slave.noarch: W: dangerous-command-in-%postun userdel ^^^ Deleting users automatically is a very very bad practice and should be omitted entirely. I strongly encourage you to remove the '%postun slave' section entirely. Let system administrator to decide whether or not to remove users from the system. 4 packages and 0 specfiles checked; 7 errors, 6 warnings. sulaco ~: + The package is named according to the Package Naming Guidelines. + The spec file name matches the base package %{name}, in the format %{name}.spec. + The package meets the Packaging Guidelines. + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The License field in the package spec file matches the actual license (3-clause BSD). + The file, containing the text of the license(s) for the package, is included in %doc. + The spec file is written in American English. + The spec file for the package is legible. + The sources used to build the package, match the upstream source, as provided in the spec URL. sulaco ~/rpmbuild/SOURCES: sha256sum Bitten-0.6b3.tar.gz* d3167fe928bb8d61e4367d71a6c286915c58f435b155c1886e0fea141f0501a8 Bitten-0.6b3.tar.gz d3167fe928bb8d61e4367d71a6c286915c58f435b155c1886e0fea141f0501a8 Bitten-0.6b3.tar.gz.1 sulaco ~/rpmbuild/SOURCES: + The package successfully compiles and builds into binary rpms on at least one primary architecture. See koji links above. + All build dependencies are listed in BuildRequires. 0 No need to handle locales. 0 No shared library files. + The package does NOT bundle copies of system libraries. + The package is not designed to be relocatable. + The package owns all directories that it creates. + The package does not list a file more than once in the spec file's %files listings. + Permissions on files are set properly. + The package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + The package consistently uses macros. + The package contains code, or permissible content. 0 No extremely large documentation files. + Anything, the package includes as %doc, does not affect the runtime of the application. 0 No header files. 0 No static libraries. 0 No pkgconfig(.pc) files. 0 The package doesn't contain library files with a suffix (e.g. libfoo.so.1.1). 0 No devel sub-package. + The package does NOT contain any .la libtool archives. 0 Not a GUI application. + The package does not own files or directories already owned by other packages. + At the beginning of %install, the package runs rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + All filenames in rpm packages are valid UTF-8. Ok, the only issue is the user removal during uninstalling - please, remove it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review