[Bug 673665] Review Request: R-XML - Tools for parsing and generating xml within R and s-plus

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=673665

HaÃkel GuÃmar <karlthered@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #1 from HaÃkel GuÃmar <karlthered@xxxxxxxxx> 2011-02-12 14:41:38 EST ---
R-XML

all relevant MUST and SHOULD points are listed here.

Must: rplint on src.rpm and binary rpms   OK 
$ rpmlint -iv R-XML-3.2.0-1.fc14.src.rpm                                        
R-XML.src: I: checking
R-XML.src: I: checking-url
http://cran.at.r-project.org/src/contrib/XML_3.2-0.tar.gz (timeout 10 seconds)
R-XML.src: I: checking-url
http://cran.at.r-project.org/src/contrib/XML_3.2-0.tar.gz (timeout 10 seconds)
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint -iv R-XML-3.2.0-1.fc14.x86_64.rpm                                     
R-XML.x86_64: I: checking
R-XML.x86_64: I: checking-url
http://cran.at.r-project.org/src/contrib/XML_3.2-0.tar.gz (timeout 10 seconds)
1 packages and 0 specfiles checked; 0 errors, 0 warnings

MUST: package is named accordingly to general and R specific naming guidelines.
OK
Note: seems that using real names in changelog is no more written in
guidelines, but it's a good practice, and i expect that you follow it.

MUST: spec file name matches %{name} OK

MUST: package meet packaging guidelines. OK 

MUST: package is licensed under a fedora compliant license (BSD) OK

MUST: spec is written in legible american english. OK

MUST: provided and upstream sources checksums match.  OK
provided sources: d862067f93f4b63feda6f80d0e307591452b0990
upstream sources: d862067f93f4b63feda6f80d0e307591452b0990

MUST: compilation tested on all supported platforms (x86 and x86_64) for F14
under mock. OK

MUST: package doesn't bundle third party libraries. OK

MUST: package owns created directories (and only them). OK

MUST: files are not listed twice. OK

MUST: files permissions are properly set. OK

MUST: consistent use of macros. OK

MUST: only ships permissible content. OK

MUST: doc is properly handled. OK

MUST: filenames are valid UTF-8. OK 

General and R specific guidelines are respected, under the reserve that you use
your real name in changelog (i have confidence that you'll fix this trivial
issue), i'll approve this package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]