Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676187 Ian Weller <ian@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(asalkeld@xxxxxxxx | |om) --- Comment #4 from Ian Weller <ian@xxxxxxxxxxxxx> 2011-02-11 15:45:54 EST --- Line 33: You create and install to /etc/xinetd.d. You shouldn't be creating this directory; add xinetd to your BuildRequires instead. [ OK ] specfiles match: 5f5579ec396913a6070e57002f61d02ed407cf81 csync2.spec 5f5579ec396913a6070e57002f61d02ed407cf81 csync2.spec.1 [ OK ] source files match upstream: 59b95388d378b659d64d17f7b736068dec7bf7ed csync2-1.34.tar.gz 59b95388d378b659d64d17f7b736068dec7bf7ed csync2-1.34.tar.gz.1 [ OK ] package meets naming and versioning guidelines. [ OK ] spec is properly named, cleanly written, and uses macros consistently. [ OK ] dist tag is present. [ OK ] build root is correct. [ OK ] license field matches the actual license. [ OK ] license is open source-compatible. [ OK ] license text included in package. [ OK ] latest version is being packaged. [FAILED] BuildRequires are proper. See the above message regarding line 33. Otherwise, the build logs from Koji look solid. [ OK ] compiler flags are appropriate. [ OK ] %clean is present. [ OK ] package builds in mock. [ OK ] package installs properly. [ OK ] debuginfo package looks complete. [ ] rpmlint is silent. Obviously, yeah, the no-manual-page-for-binary warning is just a warning. On the other hand, I feel like the PEM files would be better put somewhere in /var/lib, unless the files are meant to be user-configurable. Could you explain more about what these files are used for in the context of this application? What seems most likely is that you'll have to either move them out of /etc, or tag them as %config(noreplace). [FAILED] final provides and requires are sane There is no reason to list openssl and sqlite2, as RPM automatically adds the appropriate library requirements. Keep xinetd in there, though. [ N/A ] %check is present and all tests pass: [ OK ] no shared libraries are added to the regular linker search paths. [ OK ] owns the directories it creates. [ OK ] doesn't own any directories it shouldn't. [ OK ] no duplicates in %files. [ OK ] file permissions are appropriate. [FAILED] scriptlets match those on ScriptletSnippets page. NEVER change /etc/services. This is especially not OK because it's difficult to automatically remove this line after the package is uninstalled. [ OK ] code, not content. [ OK ] documentation is small, so no -docs subpackage is necessary. [ OK ] %docs are not necessary for the proper functioning of the package. [ OK ] no headers. [ OK ] no pkgconfig files. [ OK ] no libtool .la droppings. [ N/A ] desktop files valid and installed properly. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review