Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pybluez - python API for the bluez bluetooth stack https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218678 cr33dog@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cr33dog@xxxxxxxxx ------- Additional Comments From cr33dog@xxxxxxxxx 2006-12-14 21:12 EST ------- This is my first review. I cannot officially review the package - this is just a "pre-review". The SRPM passes rpmlint. It builds in mock fc6-i386, which is a good sign. I notice a couple of issues with the spec file, however: * You need to remove the appropriate line (and the comment) from the beginning of the spec file. At appears that this is an arch-specific(?) package, so you need to remove the '%{!?python_sitelib' line. * I think you should remove the comment from the Build section, and also the one from above '%{python_sitearch}/*' According to http://fedoraproject.org/wiki/Packaging/Guidelines#head-b7d622f4bb245300199c6a33128acce5fb453213: * The changelog items should begin with a dash. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review