Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=663926 --- Comment #4 from Hans de Goede <hdegoede@xxxxxxxxxx> 2011-02-10 05:40:13 EST --- Full review done: Good: ----- - rpmlint checks return: lsyncd.src: W: spelling-error %description -l en_US inotify -> notify, i notify, inotropic lsyncd.src: W: spelling-error %description -l en_US rsync -> sync, r sync, Syncom lsyncd.src: W: spelling-error %description -l en_US filesystems -> file systems, file-systems, ecosystems lsyncd.src: W: spelling-error %description -l en_US blockdevices -> block devices, block-devices, blockades lsyncd.src: W: spelling-error %description -l en_US filesystem -> file system, file-system, systematic <blergh, ignore> lsyncd.src:10: W: macro-in-comment %{name} lsyncd.src:10: W: macro-in-comment %{version} <idem> lsyncd.src: W: no-cleaning-of-buildroot %clean lsyncd.src: W: no-buildroot-tag lsyncd.src: W: no-%clean-section <this is ok for newer Fedora versions> lsyncd.src: W: invalid-url Source0: lsyncd-2.0.0.tar.gz <explained with comment in spec> lsyncd.x86_64: W: spelling-error %description -l en_US inotify -> notify, i notify, inotropic lsyncd.x86_64: W: spelling-error %description -l en_US rsync -> sync, r sync, Syncom lsyncd.x86_64: W: spelling-error %description -l en_US filesystems -> file systems, file-systems, ecosystems lsyncd.x86_64: W: spelling-error %description -l en_US blockdevices -> block devices, block-devices, blockades lsyncd.x86_64: W: spelling-error %description -l en_US filesystem -> file system, file-system, systematic <blergh, ignore> - package meets naming guidelines - package meets packaging guidelines - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Needs work: ----------- - rpmlint checks return: lsyncd.x86_64: W: executable-stack /usr/bin/lsyncd Nasty, not good, no idea why it is doing this. May have something to do with lua? - spec says license is GPLv2, but the copyright headers contain "or any later version", should be GPLv2+ - googlecode now seems to have sane download urls, for example: http://lsyncd.googlecode.com/files/lsyncd-2.0.0.tar.gz - upstream has a new 2.0.2 release available -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review