[Bug 675914] Review Request: flush - GTK-based BitTorrent client

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=675914

--- Comment #4 from Peter Lemenkov <lemenkov@xxxxxxxxx> 2011-02-08 07:03:43 EST ---
Unfotrunately it failed to build in Koji. Please, fix this issue.

There are other issues:

1) The directory %{_datadir}/%{name} is left unowned. Please fix the %files
section in the following  way:

- %{_datadir}/%{name}/*
+ %{_datadir}/%{name}/

Note that I stripped trailing asterisk thus claiming ownership on the entire
directory (not only on their contents).

2) The following change *should* be done with patch instead of sed. 

sed -i -e 's|strerror(e.system_error())|EE(e)|g' \
        src/create_torrent_dialog.cpp

3) Please, ensure that none of bundled libaries (dbus-c++, libconfig,
libtorrent) are used during building. I suggest you to remove both of then in
the %prep section.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]