Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=571019 --- Comment #11 from Hans de Goede <hdegoede@xxxxxxxxxx> 2011-02-08 04:10:44 EST --- Hi, (In reply to comment #10) > (In reply to comment #9) > > Hmm, it seems the .src.rpm is 404 too. Please fix that, I need to src.rpm to > > complete the review. In the mean time I've done most of the review based on the > > .spec file: > > What's the point of providing the .spec file if it's generated from the .spec > and tarball? (both have been provided) > The src.rpm is what eventually will get imported into the buildsystem / package git. By providing it, you allow the reviewer to verify the tarbal as it will get imported. The reviewer can then verify that this matches the one provided by upstream. > Anyway, libmtag: > http://people.freedesktop.org/~felipec/fedora/libmtag.spec > http://people.freedesktop.org/~felipec/fedora/libmtag-0.3.6-1.fc14.src.rpm > Thanks! Looks good now. I'll approve this as soon as I'm ready to sponsor you (once the libmtag-python package is also reviewed). > libmtag-python: > http://people.freedesktop.org/~felipec/fedora/libmtag-python.spec > http://people.freedesktop.org/~felipec/fedora/libmtag-python-0.3.1-1.fc14.src.rpm > Thanks, please file a separate review bug for this, using the usual template and let me know the bz number. Regards, Hans -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review