Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=668243 --- Comment #19 from Ralf Corsepius <rc040203@xxxxxxxxxx> 2011-02-08 01:45:02 EST --- (In reply to comment #18) > > - Instead of using %dir %{_includedir}/qb/ and listing each file in it > > individually, clean up your %files list by just listing %{_includedir}/qb/ -- > > without the %dir command, it will include that directory and everything in > > it. > In my head, the one liner is clearly easier to read in a spec file, but listing > all files has other benefits, such as detecting possible leaks of unwanted > files in there (an upstream build error for example), or possible API changes > by moving functions around to new headers, and that would allow the packagers > to easily spot them and possible notify the API users It's much a matter of personal preference. Some people prefer "this way", others "that way". I for one prefer the "one liner approach", because of its simplicity. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review