[Bug 669311] Review Request: mupdf - A lightweight PDF viewer and toolkit written in portable C

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=669311

--- Comment #27 from Mohamed El Morabity <pikachu.2014@xxxxxxxxx> 2011-02-07 04:35:10 EST ---
The devel subpackage needs to provide also mupdf-static, as described in the
guidelines, since it contains only a static library:
   %package devel
   Summary:        Development files for %{name}
   Group:          Development/Libraries
   Requires:       %{name} = %{version}-%{release}
   Provides:       %{name}-static = %{version}-%{release}

rpmlint detects bad rights on libmupdf.a:
   mupdf-devel.x86_64: W: spurious-executable-perm /usr/lib64/libmupdf.a
You should set its rights to 0644 in %install.

(In reply to comment #19)
> Just a small comment: you should use %{_prefix} instead of /usr explicitely:
>      make DESTDIR=%{buildroot} install prefix=%{buildroot}/%{_prefix} LIBDIR=%{buildroot}%{_libdir}
Don't forget this too ;)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]