Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=592487 Jason Tibbitts <tibbs@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #22 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2011-02-04 18:19:17 EST --- I've been sick for several days and have just now been able to make it back to this ticket. Unfortunately now I find that it fails to build in rawhide. Since -Wall is being passed and there are some new complaints in the absolutely new GCC that's appeared recently, things fail: e/ffgtk/html/\" -DLIBEXECDIR=\"/usr/libexec/\" -rdynamic -Wall -Werror -D_GNU_SOURCE -DLOCALE_DIR=\"/usr/share/locale/\" -g -DUSE_OLD_SPOOLER -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -c -o ffgtk-callmonitor.o `test -f 'callmonitor.c' || echo './'`callmonitor.c address-dialog.c: In function 'AddressBook': address-dialog.c:757:13: error: variable 'psInfoBox' set but not used [-Werror=unused-but-set-variable] cc1: all warnings being treated as errors server.c: In function 'PrintServerInit': server.c:125:11: error: variable 'psServer' set but not used [-Werror=unused-but-set-variable] cc1: all warnings being treated as errors make[2]: *** [ffgtk-address-dialog.o] Error 1 make[2]: *** Waiting for unfinished jobs.... make[2]: *** [ffgtk-server.o] Error 1 monitor.c: In function 'showNotification': monitor.c:213:13: error: variable 'psAddButton' set but not used [-Werror=unused-but-set-variable] monitor.c: In function 'InitMonitor': monitor.c:732:11: error: variable 'psMonitor' set but not used [-Werror=unused-but-set-variable] cc1: all warnings being treated as errors make[2]: *** [ffgtk-monitor.o] Error 1 profiles.c: In function 'setActiveProfile': profiles.c:162:11: error: variable 'psCallList' set but not used [-Werror=unused-but-set-variable] cc1: all warnings being treated as errors make[2]: *** [ffgtk-profiles.o] Error 1 It does build fine on F14, and at this point I'm just going to go with that because the rawhide breakage is recent and for all I know could be transient. If not, however, you will have to deal with that at some point soon or this package will not make it into F15. I'm still a bit wary of the scriptlets. I checked the cups-pdf package and while you're correct that it does this kind of thing, it isn't exactly a good package to use as a model. Still, it doesn't violate any guidelines and seems to be safe enough. The other stuff that needed fixing is fixed, so I'm going to say this is done. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review