Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=673485 --- Comment #3 from Matthew Barnes <mbarnes@xxxxxxxxxx> 2011-02-03 15:44:35 EST --- * MUST: The License field in the package spec file must match the actual license. Seems to be the case from the random sample of source files I looked at, but a LICENSE or COPYING file in the top-level directory would be more helpful. * MUST: Packages must NOT bundle copies of system libraries. The /lib directory contains several libraries which are packaged separately in Fedora, but they don't appear to be used during building nor are they installed. Just wanted to confirm that this is true. Other: * Package builds fine under mock in a Rawhide environment. * The BuildRoot tag isn't needed in current Fedora releases, but I see conditionals for older Fedora / RHEL releases. Not sure which releases you're targeting. Might be needed for older releases, just wanted to mention it. * In the "tools" subpackage I see: Requires: libldb >= %{version}-%{release} Should that be '=' instead of '>='? It's '=' in all other subpackages. Other than these nitpicky things, it looks good to me. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review