[Bug 216103] Review Request: python-twisted-names - A Twisted DNS implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-twisted-names - A Twisted DNS implementation


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216103





------- Additional Comments From paul@xxxxxxxxxxxx  2006-12-14 02:34 EST -------
(In reply to comment #1)
> Issues:
> 
> 1. Why the
> %{?!python:%define python python}
> macro? It just means you have "%{python}" instead of "python" in several places.
> How is that a win?

I suspect that Thomas has added this so that the package can be built on older
distros with recent pythons installed as "python24" etc.

> 2. You should include the shipped LICENSE file as a doc.

+1

> 3. For devel (python 2.5) you need to add:
> BuildRequires: python-devel

+1

> 4. rpmlint says:
> E: python-twisted-names no-binary
> 
> Shouldn't this package be noarch?

No, this is correct since some of the Twisted packages are arch-specific and
python's module code doesn't like a single module hierarchy split between the
arch-specific and arch-independent directory locations. So all of the
python-twisted-* packages have to be arch-specific.

> W: python-twisted-names doc-file-dependency
> /usr/share/doc/python-twisted-names-0.3.0/examples/dns-service.py /usr/bin/python
> W: python-twisted-names doc-file-dependency
> /usr/share/doc/python-twisted-names-0.3.0/examples/gethostbyname.py /usr/bin/env
> 
> Perhaps make those mode 644 ? 444?

They aren't really adding any extra deps; the first is a dep on python, which is
already required by this package, and the second is a dep on coreutils, which
every system is going to have anyway.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]