Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=672779 --- Comment #3 from Petr Pisar <ppisar@xxxxxxxxxx> 2011-02-03 06:01:05 EST --- Source tar ball is original. Ok. Summary verified from lib/Module/Metadata.pm. Ok. License verified from lib/Module/Metadata.pm. Ok. No XS. BuildArch ok. Description copied from %summary as upstream does not provide any. Ok. Note: You can use the macro to avoid duplication in spec file. Note: You can remove the BuildRoot code if you are not willing to support EPEL<=5 . TODO: BuildRequire perl(File::Spec) (lib/Module/Metadata.pm:17) as the package can dual-live in the future (http://search.cpan.org/~smueller/PathTools/). TODO: BuildRequire perl(IO::File) (lib/Module/Metadata.pm:18) as the package can dual-live in the future (http://search.cpan.org/~gbarr/IO/). TODO: BuildRequire perl(File::Temp) (t/lib/MBTest.pm:7) as the package can dual-live in the future (http://search.cpan.org/~tjenness/File-Temp/). TODO: BuildRequire perl(Exporter) (t/lib/MBTest.pm:66) as the package can dual-live in the future (http://search.cpan.org/~ferreira/Exporter/). TODO: BuildRequire perl(Cwd) (t/lib/MBTest.pm:69) as the package can dual-live in the future (http://search.cpan.org/~smueller/PathTools/). TODO: BuildRequire perl(File::Path) (t/lib/DistGen.pm:16) as the package can dual-live in the future (http://search.cpan.org/~dland/File-Path/) TODO: BuildRequie perl(Data::Dumper) (t/lib/DistGen.pm:20) as the package can dual-live in the future (http://search.cpan.org/~smueller/Data-Dumper/) perl(Module::Build) used at t/lib/DistGen.pm:528 is not loaded at test-time. Ok. All tests pass. Ok. $ rpmlint perl-Module-Metadata.spec ../SRPMS/perl-Module-Metadata-1.000004-1.fc15.src.rpm ../RPMS/noarch/perl-Module-Metadata-1.000004-1.fc15.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Module-Metadata-1.000004-1.fc15.noarch.rpm drwxr-xr-x 2 root root 0 Feb 3 11:27 /usr/share/doc/perl-Module-Metadata-1.000004 -rw-r--r-- 1 root root 790 Feb 3 08:54 /usr/share/doc/perl-Module-Metadata-1.000004/Changes -rw-r--r-- 1 root root 3157 Feb 3 11:27 /usr/share/man/man3/Module::Metadata.3pm.gz drwxr-xr-x 2 root root 0 Feb 3 11:27 /usr/share/perl5/Module -rw-r--r-- 1 root root 20759 Feb 3 08:53 /usr/share/perl5/Module/Metadata.pm File layout and permissions Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Module-Metadata-1.000004-1.fc15.noarch.rpm | sort | uniq -c 1 perl(File::Find) 1 perl(File::Spec) 1 perl(IO::File) 1 perl(:MODULE_COMPAT_5.12.3) 1 perl(strict) 1 perl(vars) 1 perl(version) >= 0.87 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Module-Metadata-1.000004-1.fc15.noarch.rpm | sort | uniq -c 1 perl(Module::Metadata) = 1.000004 1 perl-Module-Metadata = 1.000004-1.fc15 Binary provides Ok. $ resolvedeps-f15 perl-Module-Metadata-1.000004-1.fc15.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F15 (http://koji.fedoraproject.org/koji/taskinfo?taskID=2759587). Ok. Otherwise package is in line with Fedora and perl packaging guide lines. Resolution: Package APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review