Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674672 Bill Nottingham <notting@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |notting@xxxxxxxxxx --- Comment #2 from Bill Nottingham <notting@xxxxxxxxxx> 2011-02-02 16:40:40 EST --- - Package meets naming and packaging guidelines - OK - Spec file matches base package name. - OK - Spec has consistent macro usage. - OK - Meets Packaging Guidelines. - OK - License - LGPvL2+ - License field in spec matches - OK - License file included in package - OK - Spec in American English - OK - Spec is legible. - OK - Sources match upstream md5sum: da397528a9fa80bfa236d5e6b871896fd72e48b6eab0a056ce05231e94766217 libwnck-2.91.6.tar.bz2 - OK - Package needs ExcludeArch - N/A - BuildRequires correct - *** Looks like it may not actually use libXt. - Spec handles locales/find_lang - OK - Package is relocatable and has a reason to be. - N/A - Package has %defattr and permissions on files is good. - OK - Package is code or permissible content. - OK - Doc subpackage needed/used. - N/A - Packages %doc files don't affect runtime. - OK - Headers/static libs in -devel subpackage. - OK - Spec has needed ldconfig in post and postun - OK - .pc files in -devel subpackage/requires pkgconfig - .so files in -devel subpackage. - OK - -devel package Requires: %{name} = %{version}-%{release} - OK - .la files are removed. - OK - Package is a GUI app and has a .desktop file - N/A - Package compiles and builds on at least one arch. - OK (tested x86_64) - Package has no duplicate files in %files. - OK - Package doesn't own any directories other packages own. - OK - Package owns all the directories it creates. - OK - No rpmlint output. - *** libwnck3-devel.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/wnckprop ['/usr/lib64'] libwnck3-devel.x86_64: W: no-manual-page-for-binary wnckprop Fixing the RPATH would be nice; other can be ignored. libwnck3.x86_64: W: spelling-error %description -l en_US libwnck -> licking No comment. libwnck3.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/wnck-urgency-monitor ['/usr/lib64'] libwnck3.x86_64: W: no-manual-page-for-binary wnck-urgency-monitor Again, fixing the RPATH might be nice. - final provides and requires are sane - looks OK SHOULD Items: - Should build in mock. - tested x86_64 - Should function as described. - didn't test - Should have sane scriptlets. - OK - Should have subpackages require base package with fully versioned depend. - OK - Should have dist tag - OK - Should package latest version - OK Issues: 1. This package conflicts with libwnck: file /usr/bin/wnck-urgency-monitor from install of libwnck3-2.91.6-1.fc15.x86_64 conflicts with file from package libwnck-2.30.4-1.fc15.x86_64 file /usr/bin/wnckprop from install of libwnck3-devel-2.91.6-1.fc15.x86_64 conflicts with file from package libwnck-devel-2.30.4-1.fc15.x86_64 This needs fixed. 2. Clean out the changelog 3. Fix rpaths, if possible 4. Fix libXt-devel buildreq, if you're bored -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review