Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=668822 --- Comment #4 from Minnikhanov <minnikhanov@xxxxxxxxx> 2011-02-02 13:18:16 EST --- Looks good. May be approved with some notes. (In reply to comment #3) > > * %clean > > - %clean section is no longer needed (on Fedora): > > https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean > > > > Done > - Don't change in spec-file. > (In reply to comment #2) > > * %install > > - Gems have permission 664, need 'chmod 644' > > Which files are you refering to here? > I extract 'memcache-client-1.8.5.gem' from src.rpm at my box, it have permission 664. My box: [pkg@lhost ~]$ rpmlint -V rpmlint version 1.0 Copyright (C) 1999-2007 Frederic Lepied, Mandriva [pkg@lhost ~]$ uname -r 2.6.35.10-74.fc14.x86_64 [pkg@lhost ~]$ uname -a Linux lhost.ldomain 2.6.35.10-74.fc14.x86_64 #1 SMP Thu Dec 23 16:04:50 UTC 2010 x86_64 x86_64 x86_64 GNU/Linux [pkg@lhost updt]$ rpmbuild --version RPM version 4.8.1 ------------------------------------------------------------------------------- At my box 'rpmbuild' FAILED. error log: >>> ... error: Installed (but unpackaged) file(s) found: /usr/lib/ruby/gems/1.8/gems/memcache-client-1.8.5/.yardoc/checksums /usr/lib/ruby/gems/1.8/gems/memcache-client-1.8.5/.yardoc/objects/Cache.dat /usr/lib/ruby/gems/1.8/gems/memcache-client-1.8.5/.yardoc/objects/Cache/add_c.dat /usr/lib/ruby/gems/1.8/gems/memcache-client-1.8.5/.yardoc/objects/Cache/delete_c.dat /usr/lib/ruby/gems/1.8/gems/memcache-client-1.8.5/.yardoc/objects/Cache/get_c.dat /usr/lib/ruby/gems/1.8/gems/memcache-client-1.8.5/.yardoc/objects/Cache/logger_c.dat /usr/lib/ruby/gems/1.8/gems/memcache-client-1.8.5/.yardoc/objects/Cache/put_c.dat /usr/lib/ruby/gems/1.8/gems/memcache-client-1.8.5/.yardoc/objects/Cache/reset_c.dat /usr/lib/ruby/gems/1.8/gems/memcache-client-1.8.5/.yardoc/objects/Continuum.dat /usr/lib/ruby/gems/1.8/gems/memcache-client-1.8.5/.yardoc/objects/EM.dat ... like this 23Kb <<< koji scratch build green, here no these error messages http://koji.fedoraproject.org/koji/taskinfo?taskID=2757774 ------------------------------------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review