Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674060 --- Comment #3 from VÃt Ondruch <vondruch@xxxxxxxxxx> 2011-02-02 11:05:25 EST --- * Check - pushd ./%{geminstdir} is not stepping into the correct directory. The right one is: pushd %{buildroot}%{geminstdir} * Shipping external project - This gem bundles external project in support folder. On Fedora shipping external project in the same package should (must) be avoided, see: https://fedoraproject.org/wiki/Packaging/Guidelines#Bundling_of_multiple_projects * Missing dependencies - Since this is Sinatra application, there have to be specified appropriate dependencies: Require: rubygem(sinatra) BuildRequire: rubygem(sinatra) - Missing rubygem-net-ssh dependency. Not sure if it is runtime or just development dependency - There are missing plenty of others, such as rack. Please test using mock. * rpmlint output: - Is this package ahead of upstream? $ rpmlint rubygem-deltacloud-core.spec rubygem-deltacloud-core.spec: W: invalid-url Source0: http://gems.rubyforge.org/gems/deltacloud-core-0.2.0.gem HTTP Error 404: Not Found 0 packages and 1 specfiles checked; 0 errors, 1 warnings. I am not going forward with this review, since I cannot build on my environment due to missing dependencies. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review