Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=668824 --- Comment #3 from Mohammed Morsi <mmorsi@xxxxxxxxxx> 2011-02-01 18:21:59 EST --- Thanks alot for the review. Updated the rpm based on feedback: Spec URL: http://mo.morsi.org/files/rpms/rubygem-text-hyphen.spec SRPM URL: http://mo.morsi.org/files/rpms/rubygem-text-hyphen-1.0.0-2.fc14.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2755541 If your taking this official review, please change the status of the bug to 'assigned', assign it to yourself, and change the 'fedora-review' flag to '?' (In reply to comment #1) > Some notes: > > * License > - Must be pick up one or set another by LICENSE file. Done. The licensing situation in this package is ugly (even says so in the LICENSE file). But I think I got it through the combination of including all the necessary licenses and removing the files with licenses incompatible for Fedora. This should be verified though. > > * BuildRoot > - On Fedora BuildRoot line is no longer needed: > https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag > Done > * %description > - This section is empty. It will be better to fill. > Done > * %install > - rm -rf %{buildroot} at the beginning of %install isn't needed and > should be removed > Done > * %check > - Feel free run test suite in a %check section in the rpm > Done > * %clean > - %clean section is no longer needed (on Fedora): > https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean > Done > * %files > - Should use only the defined %geminstdir macro in %files. > - Some files and folders don't listed here. > Done > * documents / -doc subpackage > - Please consider to split document files (which are not > needed on runtime) to -doc subpackage. > The following files/directories can be moved to -doc subpackage > ------------------------------------------------------ > %{gemdir}/doc/%{gemname}-%{version}/ > %{geminstdir}/ChangeLog > %{geminstdir}/tests/ > # next line publish in Bugzilla? > %{geminstdir}/Rakefile - I don't know where it must be. May be it need > only for tests. > ------------------------------------------------------ > I'm going to leave it as is since the original gem ships w/ these files and there aren't too many of them. The necessary files have been marked as %doc though. > * rpmbuild log: > ------------------------------------------------------ > ... > + gem install --local > --install-dir > /home/pkg/rpmbuild/BUILDROOT/rubygem-text-hyphen-1.0.0-1.fc14.x86_64/usr/lib/ruby/gems/1.8 > --force --rdoc /home/pkg/rpmbuild/SOURCES/text-hyphen-1.0.0.gem > + /usr/lib/rpm/check-rpaths /usr/lib/rpm/check-buildroot > + /usr/lib/rpm/redhat/brp-compress > + /usr/lib/rpm/redhat/brp-strip /usr/bin/strip > + /usr/lib/rpm/redhat/brp-strip-comment-note /usr/bin/strip /usr/bin/objdump > + /usr/lib/rpm/redhat/brp-strip-static-archive /usr/bin/strip > + /usr/lib/rpm/brp-python-bytecompile /usr/bin/python 1 > + /usr/lib/rpm/redhat/brp-python-hardlink > + /usr/lib/rpm/redhat/brp-java-repack-jars > warning: File listed > twice: /usr/lib/ruby/gems/1.8/gems/text-hyphen-1.0.0/ChangeLog > warning: File listed > twice: /usr/lib/ruby/gems/1.8/gems/text-hyphen-1.0.0/INSTALL > warning: File listed > twice: /usr/lib/ruby/gems/1.8/gems/text-hyphen-1.0.0/LICENCE > warning: File listed > twice: /usr/lib/ruby/gems/1.8/gems/text-hyphen-1.0.0/README > + umask 022 > + cd /home/pkg/rpmbuild/BUILD > + rm > -rf /home/pkg/rpmbuild/BUILDROOT/rubygem-text-hyphen-1.0.0-1.fc14.x86_64 > + exit 0 > ------------------------------------------------------ > > - There is twice definition - may be in %files Done. > > * rpmlint log: > ------------------------------------------------------ > rubygem-text-hyphen.noarch: E: summary-too-long C Multilingual word > hyphenation according to modified TeX hyphenation pattern files Done > rubygem-text-hyphen.noarch: E: no-description-tag Done > rubygem-text-hyphen.noarch: E: > non-executable-script /usr/lib/ruby/gems/1.8/gems/text-hyphen-1.0.0/Rakefile > 0644L /usr/bin/env > rubygem-text-hyphen.noarch: W: > hidden-file-or-dir /usr/lib/ruby/gems/1.8/gems/text-hyphen-1.0.0/.yardoc > rubygem-text-hyphen.noarch: W: > hidden-file-or-dir /usr/lib/ruby/gems/1.8/gems/text-hyphen-1.0.0/.yardoc > rubygem-text-hyphen.noarch: E: > non-executable-script /usr/lib/ruby/gems/1.8/gems/text-hyphen-1.0.0/bin/hyphen > 0644L /usr/bin/env Not getting these locally, perhaps I fixed as part of something else? > rubygem-text-hyphen.noarch: W: > unexpanded-macro > /usr/lib/ruby/gems/1.8/doc/text-hyphen-1.0.0/ri/Text/Hyphen/clear_cache%21-i.yaml Can be ignored, occurs in alot of ruby packages. > %21 > rubygem-text-hyphen.noarch: E: > non-executable-script > /usr/lib/ruby/gems/1.8/gems/text-hyphen-1.0.0/tests/tc_text_hyphen.rb 0644L > /usr/bin/env > rubygem-text-hyphen.src: E: summary-too-long C Multilingual word > hyphenation according to modified TeX hyphenation pattern files > rubygem-text-hyphen.src: E: no-description-tag > 2 packages and 1 specfiles checked; 7 errors, 3 warnings. > ------------------------------------------------------ (In reply to comment #2) > * %install > - Gem have permission 664, need 'chmod 644' Which file are you referring to here? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review