[Bug 668090] Review Request: rubygem-railties - Rails internals: application bootup, plugins, generators, and rake tasks.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=668090

--- Comment #10 from Minnikhanov <minnikhanov@xxxxxxxxx> 2011-02-01 14:04:26 EST ---
Spec URL: http://dl.dropbox.com/u/14118661/rubygem-railties.spec
SRPM URL:
http://dl.dropbox.com/u/14118661/rubygem-railties-3.0.3-6.fc14.src.rpm 

koji scratch build: green
http://koji.fedoraproject.org/koji/taskinfo?taskID=2755487

(In reply to comment #9)
> (In reply to comment #8)
> 
> Thanks for these updated rpms, since the tests don't pass but we've verified
> functionality, could you comment the check section for the time being. I don't
> like relying on the fact that 'rake test' doesn't return a non-zero exit code
> when the tests fail in railties. You can also comment the BuildRequires needed
> for the tests for the time being.
> 

+ Fixed. Test excluded.

> suite and one additional nit. As with the mail gem, the "fix any executable
> that doesn't have a shebang" and "find files with a shebang that do not have
> executable permissions" sections seem to be unnecessary (I checked) and can be
> removed (they clutter the rpm build log).
> 

+ Fixed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]