Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: audacious-docklet - a docklet plugin for Audacious https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218258 ------- Additional Comments From fedora@xxxxxxxxxxxxxxxxxxxx 2006-12-13 18:42 EST ------- Some more things I'd like you to fix: - BuildRequires: are incorrect. Instead of glib-devel you mean glib2-devel. audacious-devel already requires glib2-devel and gtk2-devel, so there's no need to list them (twice). On the other hand you need gettext for %find_lang (see http://fedoraproject.org/wiki/Packaging/Guidelines#head-8c605ebf8330f6d505f384e671986fa99a8f72ee) and maybe perl(XML::Parser) for generating the locales. - better change Requires: audacious to audacious-plugins, because that packgage owns /usr/lib/audacious/(General). - there are two typos in %description, also I think that you don't need to mention the minimize feature, "control Audacious" is IMO enought. How about: "A plugin that allows you to control Audacious from the system tray."? If your description is longer, don't forget to add a line warp after 79 characters. - add "--disable-static" to %configure, because we don't want no static libs, see http://fedoraproject.org/wiki/Packaging/Guidelines#head-2302ec1e1f44202c9cc4bcce24cb711266557ad7libdocklet.a - we also don't want no libtool archives, so remove libdocklet.la after install: %find_lang %{name} rm $RPM_BUILD_ROOT/%{plugin_dir}/General/libdocklet.la - audacious-docklet-0.1.1.tar.bz2 inside of the srpm has permissions of 555, please change it to 644. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review