Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=669939 Jon Stanley <jonstanley@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonstanley@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |jonstanley@xxxxxxxxx Flag| |fedora-review+ --- Comment #1 from Jon Stanley <jonstanley@xxxxxxxxx> 2011-02-01 00:24:48 EST --- This package generally looks fine to me. A few nits: * License tag is GPLv2+ - upstream is absolutely insane and says on their website that the code is licensed under "GPL2 or any OSI approved license". This cannot possibly be true, as it uses MediaWiki API's. Looking in the COPYING file included in Subversion, however, this provision isn't in there - it's a copy of GPLv2 with a note that the extension may be distributed under the GNU General Public License: The ParserFunctions extension may be copied and redistributed under the GNU General Public License. So this in the source control would make sense, except that this cannot possibly be GPL+ either (which this language would indicate). In the end, I think that the license tag of GPL2 would probably work, as this is the only possible license that one could use this under. * Sources match upstream * License file is in package * Clean buildroot * Checkout instructions from upstream SCM included * Rpmlint clean With the license tag change, this package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review