Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=673589 --- Comment #7 from sebelk@xxxxxxxxx 2011-01-31 14:39:40 EST --- SPEC URL: http://dl.dropbox.com/u/14217893/UpTools.spec SRPM URL: http://dl.dropbox.com/u/14217893/UpTools-8.5.4-1.fc14.src.rpm I've made the following actios: +- Styles mixing fixed +- Added openssl-devel as BuildRequires +- Drop "." ant the end Summary +- Fixed BuildRoot +- Fixed Summary and Description +- Fixed %%pre and %%postun +- Fixed file-not-utf8 +- Fixed spec file name rpmlint output: rpmlint -i -v UpTools.spec UpTools.spec: I: checking-url http://www.palermo.edu/ingenieria/UpTools-8.5.4.tar.gz (timeout 10 seconds) 0 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint -v -i /home/sergio/rpmbuild/SRPMS/UpTools-8.5.4-1.fc14.src.rpm UpTools.src: I: checking UpTools.src: I: checking-url http://www.palermo.edu/ingenieria/uptools_ingles.html (timeout 10 seconds) UpTools.src: I: checking-url http://www.palermo.edu/ingenieria/UpTools-8.5.4.tar.gz (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint -v -i /home/sergio/rpmbuild/RPMS/i686/UpTools-8.5.4-1.fc14.i686.rpm UpTools.i686: I: checking UpTools.i686: I: checking-url http://www.palermo.edu/ingenieria/uptools_ingles.html (timeout 10 seconds) UpTools.i686: W: devel-file-in-non-devel-package /usr/lib/libUpTools.so A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package. 1 packages and 0 specfiles checked; 0 errors, 1 warnings. rpmlint -v -i /home/sergio/rpmbuild/RPMS/i686/UpTools-devel-8.5.4-1.fc14.i686.rpm UpTools-devel.i686: I: checking UpTools-devel.i686: I: checking-url http://www.palermo.edu/ingenieria/uptools_ingles.html (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint -v -i /home/sergio/rpmbuild/RPMS/i686/UpTools-static-8.5.4-1.fc14.i686.rpm UpTools-static.i686: I: checking UpTools-static.i686: I: checking-url http://www.palermo.edu/ingenieria/uptools_ingles.html (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 0 warnings. The only problematic thing that I see is the warning about development package creation. Should I join "UpTools+Uptools-devel" package? And what about is someone makes a program that already was linked against UpTools library? About the UpTools-devel files and about %{_includedir}/UpTools/ I see no problem about it: rpm -qlpv /home/sergio/rpmbuild/RPMS/i686/UpTools-devel-8.5.4-1.fc14.i686.rpm | grep UpTools$ drwxr-xr-x 2 root root 0 ene 31 16:05 /usr/include/UpTools You can view my task also on: http://koji.fedoraproject.org/koji/taskinfo?taskID=2753478 I look forward you review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review