[Bug 665560] Review Request: rubygem-mail - A Really Ruby Mail Library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=665560

Mohammed Morsi <mmorsi@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #18 from Mohammed Morsi <mmorsi@xxxxxxxxxx> 2011-01-31 12:53:04 EST ---
> There is not 'Gemfile.lock' in upstream - create this file by 'touch' in %prep.
> Is this right?

No, this file gets created during the build. Please remove this.

(In reply to comment #17)
> Spec URL: http://dl.dropbox.com/u/14118661/rubygem-mail.spec
> SRPM URL: http://dl.dropbox.com/u/14118661/rubygem-mail-2.2.15-1.fc14.src.rpm
> 
> Updated to latest upstream release (v.2.2.15 25/01/2011)
> 
> Spec(previous) URL:
>  http://dl.dropbox.com/u/14118661/rubygem-mail-2.2.14-5.fc14.spec


Once the touch 'Gemfile.lock' is removed, everything looks go. The package
depends on bundler (BZ #646836), which has been approved but not pushed yet.
The package builds fine in mock though with the bundler rpm preinstalled.


APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]