Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=673589 --- Comment #5 from sebelk@xxxxxxxxx 2011-01-31 08:11:44 EST --- New SPEC URL: http://pastebin.com/4HyTTH0N Jussi, thanks for taking the time for view the package. I've made the suggested changes to spec file. Please bear in mind that UpTools is a young project. Because of it, we would want that users can learn how to use it through examples in %{_defaultdocdir}/%{name}-%{version}/tests/* The are documentation files. There are not examples to "test the suite" in the automake "make check" style. I'd be glad to get your feedback and sponsorship. Below you there is the rmplint output: uptools.spec:119: W: macro-in-comment %pre There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. uptools.spec: I: checking-url http://www.palermo.edu/ingenieria/UpTools-8.5.4.tar.gz (timeout 10 seconds) 0 packages and 1 specfiles checked; 0 errors, 1 warnings. UpTools.i686: I: checking UpTools.i686: W: spelling-error Summary(en_US) hpc -> hp, pc, hic The value of this tag appears to be misspelled. Please double-check. UpTools.i686: W: name-repeated-in-summary C UpTools The name of the package is repeated in its summary. This is often redundant information and looks silly in various programs' output. Make the summary brief and to the point without including redundant information in it. UpTools.i686: W: incoherent-version-in-changelog 8.5.4 ['8.5.4-1.fc14', '8.5.4-1'] The last entry in %changelog contains a version identifier that is not coherent with the epoch:version-release tuple of the package. UpTools.i686: I: checking-url http://www.palermo.edu/ingenieria/uptools_ingles.html (timeout 10 seconds) UpTools.i686: W: devel-file-in-non-devel-package /usr/lib/libUpTools.so A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package. UpTools.i686: W: one-line-command-in-%post /sbin/ldconfig You should use %post -p <command> instead of using: %post <command> It will avoid the fork of a shell interpreter to execute your command as well as allows rpm to automatically mark the dependency on your command for the excecution of the scriptlet. UpTools.i686: W: one-line-command-in-%postun /sbin/ldconfig You should use %postun -p <command> instead of using: %postun <command> It will avoid the fork of a shell interpreter to execute your command as well as allows rpm to automatically mark the dependency on your command for the excecution of the scriptlet. 1 packages and 0 specfiles checked; 0 errors, 6 warnings. UpTools-devel.i686: I: checking UpTools-devel.i686: I: checking-url http://www.palermo.edu/ingenieria/uptools_ingles.html (timeout 10 seconds) UpTools-devel.i686: W: file-not-utf8 /usr/share/doc/UpTools-8.5.4/tests/testUpTimer.cc The character encoding of this file is not UTF-8. Consider converting it in the specfile's %prep section for example using iconv(1). 1 packages and 0 specfiles checked; 0 errors, 1 warnings. UpTools-static.i686: I: checking UpTools-static.i686: W: spelling-error Summary(en_US) hpc -> hp, pc, hic The value of this tag appears to be misspelled. Please double-check. UpTools-static.i686: I: checking-url http://www.palermo.edu/ingenieria/uptools_ingles.html (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 1 warnings. UpTools-debuginfo.i686: I: checking UpTools-debuginfo.i686: I: checking-url http://www.palermo.edu/ingenieria/uptools_ingles.html (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 0 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review