Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=668243 --- Comment #13 from Angus Salkeld <asalkeld@xxxxxxxxxx> 2011-01-30 23:42:23 EST --- Hi guys Sorry for the delay I have been on holiday. I have changed upstream to: 1) only add -O and -g options if configured with either ./configure --enable-debug (adds -ggdb3 -O0) or ./configure --enable-coverage (adds -O0) So basically it won't override defaults unless requested to. 2) I have added procps and removed automake&autoconf from the BuildRequires 3) I have merged in the release system from corosync so we can have the auto*generated files included in the tarball. 4) I have released an upstream 0.4.1 to get theses changes. The new spec is here: http://libqb.org/html/libqb.spec The new srpm here: http://libqb.org/html/libqb-0.4.1-1.fc14.src.rpm tests -------- $ rpmlint -v libqb libqb.x86_64: I: checking libqb.x86_64: I: checking-url http://www.libqb.org (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint -v libqb-debuginfo libqb-debuginfo.x86_64: I: checking libqb-debuginfo.x86_64: I: checking-url http://www.libqb.org (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint -v libqb-devel libqb-devel.x86_64: I: checking libqb-devel.x86_64: I: checking-url http://www.libqb.org (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ koji build --scratch dist-f13 /home/asalkeld/rpmbuild/SRPMS/libqb-0.4.1-1.fc14.src.rpm results: http://koji.fedoraproject.org/koji/taskinfo?taskID=2751358 Thanks for the review, I hope this sorts out everything that needs to be. Regards Angus -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review