Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650667 --- Comment #10 from Martin Gieseking <martin.gieseking@xxxxxx> 2011-01-29 15:41:45 EST --- (In reply to comment #9) > Note: The sources still include the old COPYING-DOCS from previous versions. > The new Mallard-based manual is CC-licensed, as described in > /help/C/license.page. That's why I've dropped the obsolete file from the docs > list, too. Is this OK? Ah, good catch. Yes that's OK. Only license texts of actually involved licenses must be added to the package. The proper abbreviation for the Creative Commons license is CC-BY-SA (without v3.0 postfix). See here for a list of accepted licenses and their short names used in the License fields: http://fedoraproject.org/wiki/Licensing#SoftwareLicenses Here are a couple of further notes: - Don't mix spaces and tabs for indentation. Choose one of them and stick with it. - Add BR: gtk2-devel again. Only "Requires: gtk2" was supposed to be removed. - Please put the sections %post, %postun, and %posttrans between %clean and %files. It's just the usual place for the scriptlets. - Replace %{_datadir}/gnome/help/%{name}/* with %{_datadir}/gnome/help/%{name}/ Otherwise, only the content of the directory is added but the directory itself stays unowned and won't get removed when uninstalling the package. - Add %dir %{_datadir}/%{name}/ to the %files section or (alternatively) replace %{_datadir}/%{name}/%{name}.ui with %{_datadir}/%{name}/ for proper directory ownership. BTW, if you don't have a sponsor yet, I can sponsor you if you're willing to do some informal reviews of other packager's submissions in order to show an understanding of the packaging guidelines. This is important because you will be allowed to formally review and approve packages once you are sponsored. And of course you shouldn't mess your own packages either. Thus, you should know what you do. :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review