Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=658420 --- Comment #6 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2011-01-29 11:26:37 EST --- (In reply to comment #5) > According to the guidelines [1], Java packages using JNI (and thus containing a > .so file) must be installed in %{_libdir}/%{name}. Therefore, I haven't moved > the jar yet. If this part of the guidelines doesn't apply here for some reason, > please let me know. > > [1] > http://fedoraproject.org/wiki/Packaging/Java#Packaging_JAR_files_that_use_JNI That's certainly true, so this is ok. *** All the issues seem to have been fixed. However, before approving this review, I still have one final point. The directory external/json looks a bit troubling, since it is insinuating that a json library is bundled. However, there are *NO* comments whatsoever what library this is and what its upstream is. Please ask upstream where the files in external/json have been taken from, and if they have undergone modification. Please ask them also to document this in the relevant directory. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review