Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=620191 Jason Tibbitts <tibbs@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx Flag| |fedora-review+ --- Comment #12 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2011-01-27 18:13:14 EST --- Builds fine and rpmlint is silent. If you don't want this on el4 or el5 you can do the usual removal of the buildroot cleaning stuff. I tried this out but as I'm not a claws user is doesn't do all that much for me. However, it does at least start. Honestly I see nothing wrong here. I don't see any particular problem with the location of the package in the menus. * source files match upstream. sha256sum: f19720da0f7f33478394519e804db6c21c415f9fdbc567970f2394df668baa8c clawsker-0.7.2.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint is silent. * final provides and requires are sane: clawsker = 0.7.2-2.fc15 = /usr/bin/perl claws-mail perl(Glib) perl(Gtk2) perl(Locale::gettext) perl(POSIX) perl(constant) perl(encoding) perl(strict) * no bundled libraries. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * desktop files valid and installed properly. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review