Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590305 --- Comment #7 from Mark McKinstry <mmckinst@xxxxxxxxxxx> 2011-01-26 19:37:38 EST --- (In reply to comment #5) > - The .desktop file isn't installed. See here how to do it: > http://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files Doh. I read that same page about how to do the desktop file but forgot to install it. Its fixed now. > - I recommend to use fully versioned dependencies on vile-common > Requires: common = %{version}-%{release} Done. > - please replace the icon file vile.xbm with file vile.xpm as the xbm format is > not supported in desktop files (only png, svg and xpm work) Done. > - replace %{_datarootdir} with %{_datadir} to be consistent Done. Spec: http://mmckinst.nexcess.net/vile/vile-9.8d-2.fc14.src.rpm SRPM: http://mmckinst.nexcess.net/vile/vile.spec Scratch: http://koji.fedoraproject.org/koji/taskinfo?taskID=2744695 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review