Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=662259 Ben Boeckel <mathstuf@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #2 from Ben Boeckel <mathstuf@xxxxxxxxx> 2011-01-26 18:27:00 EST --- (In reply to comment #1) > Here are a few issues from the rpmlint output: > > > git-annex.src: W: invalid-url Source0: git-annex-0.11.tar.bz2 > > The Source0 needs to be a full URL, not just a filename. I can't seem to find > a tarball on the git-annex website. Can you work with upstream to get them to > publish a tarball for each new version? I'll contact him about it. It was generated from a tag in the repository (see instructions above the URL: tag). > > git-annex.x86_64: W: spurious-executable-perm /usr/share/man/man1/git-annex.1.gz Oops. > This should be fixed. > > > git-annex-debuginfo.x86_64: E: debuginfo-without-sources > > Have you tried to fix this error? The -debuginfo package actually needs disabled since Haskell doesn't support it. > A few other issues: > > 1) The %description seems a little long. Most packages seem to have one or > maybe two brief paragraphs. Taken from the website for the most part. I'll look at trimming it down. > 2) This is a dumb preference, but I would slightly change the summary to > "Manage files with git, without checking in their contents". Yeah, also taken from the website. Your wording is better. Will appear in the next version. > 3) It looks like there have been a few version updates since the last time the > spec file was updated. Will appear in the next update. (I don't keep all the RR's I have 100% up-to-date, just the ones that have attention since there are sometimes a dozen updates between be initially submitting and getting a reviewer). > 4) Have you sent the patches to the Makefile upstream? By the way, it looks > like the documentation is correctly installed by the Makefile in a newer > version of git-annex. They've been sent and applied in some way. I think the author changed around some of them. I'll look at it more closely when I update it. > 5) Two of the dependencies are unavailable on Fedora 14. I can't really do > anything more on this review until the ghc-pcre-light package is in. Hence the Blocks: field above :) . I have a local repository which I build against and has pretty much every package in the review list in it. My server has had issues since a power outage 2 or 3 weeks ago and I still haven't had a chance to look into it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review