Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=619355 Jason Tibbitts <tibbs@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx Flag| |fedora-review? --- Comment #8 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2011-01-26 18:20:31 EST --- Turns out that somehow I lost that saved review when I was cleaning up my in-progress reviews directory. Ugh. Rather than try to retype it all now, I'll go over the basic issues: All of those devel-file-in-non-devel-package complaints: These are present in the base numpy package, but this package doesn't get a pass just because the base package may be doing something dumb. I asked the current maintainer of the numpy package but he did not know what those files were actually used for. Probably best if you figure that out, given that you're going to be maintaining this. There are some additional complaints about the f2py subpackage. My understanding is that one actually does call the compiler, but then there's also the question of why stuff in the tests directory is in the final package. There are several private-shared-object-provides warnings that I'd suggest filtering if el5 had the filtering infrastructure. There's one no-soname complaint which I think is inconsequential. Otherwise I can't really complain about the package. I'll whip up a full review if we can get those questions answered. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review