Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=670451 David Nalley <david@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #6 from David Nalley <david@xxxxxxx> 2011-01-26 13:30:19 EST --- So I'll take your word on the javadoc requirement - I assume that you know the package a bit better than I do. Reading the below suggests that sub-packages should require the base package - and then of course, if it does require the base package then it should be fully versioned. I'll admit I don't grok why there wouldn't be a Requires there, but it's a 'should' not a must, so isn't a blocker. http://fedoraproject.org/wiki/Packaging/Guidelines#RequiringBasePackage The added BR takes care of building. (Of course the sonatype-oss-parent doesn't appear to be in rawhide, so a mock build will fail if it hasn't hit yet) Aside from that though, it should be ready to go - APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review