Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=672801 --- Comment #2 from Petr Pisar <ppisar@xxxxxxxxxx> 2011-01-26 13:02:51 EST --- Source tar ball is original. Ok. Summary verified from lib/Perl/OSType.pm. Ok. Description verified from lib/Perl/OSType.pm. Ok. License verified from lib/Perl/OSType.pm. Ok. BuildArch: noarch verified (no XS). Ok. Patches reviewed. Ok. Note: If you are going to keep Fedora and EPEL packages synchronized, the conditional patching is Ok. Otherwise I would prefer to remove useless patches from Fedora spec file. FIX: BuildRequire perl(File::Temp) (t/00-compile.t:16) as it can dual-live in the future (http://search.cpan.org/~tjenness/File-Temp/). FIX: BuildRequire perl(constant) (t/OSType.t:6) as it can dual-live in the future (http://search.cpan.org/~saper/constant/). FIX: BuildRequire perl(Exporter) (lib/Perl/OSType.pm:17) as it can dual-live in the future (http://search.cpan.org/~ferreira/Exporter/). BuildRequires perl(Test::CPAN::Meta), perl(Test::Pod), perl(Test::Pod::Coverage), perl(Test::Portability::Files) needed only for maintainer tests that are explicitly run. Version constrains miss as the tests are optional. Ok. All tests pass. Ok. $ rpmlint perl-Perl-OSType.spec ../SRPMS/perl-Perl-OSType-1.002-2.fc15.src.rpm ../RPMS/noarch/perl-Perl-OSType-1.002-2.fc15.noarch.rpm perl-Perl-OSType.src: W: spelling-error %description -l en_US linux -> Linux perl-Perl-OSType.src: W: spelling-error %description -l en_US freebsd -> freebased, freebase, freebie perl-Perl-OSType.noarch: W: spelling-error %description -l en_US linux -> Linux perl-Perl-OSType.noarch: W: spelling-error %description -l en_US freebsd -> freebased, freebase, freebie 2 packages and 1 specfiles checked; 0 errors, 4 warnings. The words are literals. Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Perl-OSType-1.002-2.fc15.noarch.rpm drwxr-xr-x 2 root root 0 Jan 26 17:30 /usr/share/doc/perl-Perl-OSType-1.002 -rw-r--r-- 1 root root 1009 Nov 16 15:02 /usr/share/doc/perl-Perl-OSType-1.002/Changes -rw-r--r-- 1 root root 18252 Nov 16 15:02 /usr/share/doc/perl-Perl-OSType-1.002/LICENSE -rw-r--r-- 1 root root 1850 Nov 16 15:02 /usr/share/doc/perl-Perl-OSType-1.002/README -rw-r--r-- 1 root root 2630 Jan 26 17:30 /usr/share/man/man3/Perl::OSType.3pm.gz drwxr-xr-x 2 root root 0 Jan 26 17:30 /usr/share/perl5/Perl -rw-r--r-- 1 root root 3636 Nov 16 15:02 /usr/share/perl5/Perl/OSType.pm Files layout and permission Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Perl-OSType-1.002-2.fc15.noarch.rpm | sort | uniq -c 1 perl(Exporter) 1 perl(:MODULE_COMPAT_5.12.2) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Perl-OSType-1.002-2.fc15.noarch.rpm | sort | uniq -c 1 perl(Perl::OSType) = 1.002 1 perl-Perl-OSType = 1.002-2.fc15 Binary provides Ok. $ resolvedeps-f15 ../RPMS/noarch/perl-Perl-OSType-1.002-2.fc15.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F15 (http://koji.fedoraproject.org/koji/taskinfo?taskID=2743701). Ok. Othrwise package is in line with Fedora and perl packaging guidelines. Please correct all `FIX' prefixed issues and submit new spec file. Resolution: Package NOT approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review