Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libmp4v2 a library for handling the mp4 container format https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191036 matthias@xxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |matthias@xxxxxxxxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From matthias@xxxxxxxxxxxx 2006-12-12 07:08 EST ------- Great, if we can have this in Extras. First review steps, the spec file : - Please don't mix space and tab identing in spec files (there is one tab). - I suggest you use %{version} in Source0 line to be sure not to miss an update. - You should update to your 1.5.0.1 package, I guess... - Do we want to be shipping the static library? Probably not. - You should switch to "make install DESTDIR=$RPM_BUILD_ROOT" (it works). About the build : - It compiles fine (tested FC6 x86_64), but with quite a few warnings. About the resulting packages : I tried to recompile the latest easytag, enabling libmp4v2 support, but the build failed with this error : gcc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -I/usr/include/gtk-2.0 -I/usr/lib64/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/freetype2 -I/usr/include/libpng12 -o easytag about.o ape_tag.o bar.o browser.o cddb.o charset.o crc32.o dlm.o easytag.o et_core.o flac_header.o flac_tag.o id3_tag.o misc.o monkeyaudio_header.o mpeg_header.o mp4_header.o mp4_tag.o musepack_header.o msgbox.o ogg_header.o ogg_tag.o picture.o prefs.o scan.o setting.o vcedit.o -L/lib64 -lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0 -lgdk_pixbuf-2.0 -lpangocairo-1.0 -lpango-1.0 -lcairo -lgobject-2.0 -lgmodule-2.0 -ldl -lglib-2.0 libapetag/libapetag.a id3lib/libid3bugfix.a -lmp4v2 -lz -lstdc++ -lid3 -lFLAC -lvorbisfile -lvorbis -logg -lm mp4_header.o: In function `getType': /usr/src/rpm/BUILD/easytag-1.99.13/src/mp4_header.c:125: undefined reference to `MP4GetTrackMediaDataName' mp4_header.o: In function `Mp4_Header_Read_File_Info': /usr/src/rpm/BUILD/easytag-1.99.13/src/mp4_header.c:240: undefined reference to `MP4GetTrackAudioChannels' collect2: ld returned 1 exit status The linking stage seems to be including -lmp4v2 properly, but fails to find those two functions (using 1.4.1). Do you have any idea why? Would it be a problem with libmp4v2 or with how easytag tries to use it? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review