Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=667997 --- Comment #5 from VÃt Ondruch <vondruch@xxxxxxxxxx> 2011-01-26 08:09:59 EST --- Spec URL: http://people.redhat.com/vondruch/rubygem-rack-mount.spec SRPM URL: http://people.redhat.com/vondruch/rubygem-rack-mount-0.6.13-3.fc14.src.rpm (In reply to comment #4) > > > * MUST: Packages must NOT bundle copies of system libraries, rack-mount > > > vendorizes the multimap and regin gems, these need to be separated into their > > > own rpms > > > > Bundled gems removed and added dependencies instead. > > Hrm, the code you added to the specfile doesn't quite accomplish this, instead > of the "rm -rf gems/..." line you need > > "rm -rf %{buildroot}%{geminstdir}/lib/rack/mount/vendor" > > I've verified it builds and the test suite still works as intended after this > fix. Huh ... I must be blind :) Fixed. Thank you. > > > > > > > > * Koji build is green: > > > http://koji.fedoraproject.org/koji/taskinfo?taskID=2730211 > > > > > > * Feel free to tar up the upstream test suite and Rakefile and include and run > > > them in the rpm's check section. Not a requirement for approval though. > > > > Test suite is executed now during build. Note, however, that the test suite is > > not bundled into resulting package. > > Thanks, though I'm getting the following error when I run this: > > mkdir /var/tmp/rack-mount-0.6.13 > mkdir: cannot create directory `/var/tmp/rack-mount-0.6.13': File exists > error: Bad exit status from /var/tmp/rpm-tmp.3WMbc3 (%check) > > The following accomplishes the same thing and works locally > > %check > pushd %{buildroot}%{gemdir} > tar xzvf %{SOURCE1} > ruby -rrubygems -I%{buildroot}%{geminstdir}/lib -I./test /usr/bin/testrb > test/test_* > rm -rf test/ > popd This happened because build failed for the first time (missing RUBYOPT="rubygems" in mock?). It should not ever happen on Koji. Nevertheless, I am now cleaning up the test target directory before the test preparation, so it should not happen anymore. Thank you for your review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review